Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADR] Unified API prefix #12311

Merged
merged 1 commit into from
Feb 17, 2021
Merged

[ADR] Unified API prefix #12311

merged 1 commit into from
Feb 17, 2021

Conversation

lchrusciel
Copy link
Member

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@lchrusciel lchrusciel added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Feb 5, 2021
@lchrusciel lchrusciel requested a review from a team as a code owner February 5, 2021 15:31
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Feb 5, 2021
@lchrusciel lchrusciel changed the title [ADR] New API prefix [ADR] Unified API prefix Feb 5, 2021
GSadee
GSadee approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be opened to 1.9 branch?

@lchrusciel lchrusciel changed the base branch from master to 1.9 February 17, 2021 15:48
@lchrusciel lchrusciel changed the base branch from 1.9 to master February 17, 2021 15:48
@lchrusciel lchrusciel changed the base branch from master to 1.9 February 17, 2021 15:49
@lchrusciel lchrusciel merged commit 79e7e76 into Sylius:1.9 Feb 17, 2021
@lchrusciel lchrusciel deleted the adr branch February 17, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomanhez Tomanhez Tomanhez approved these changes

@GSadee GSadee GSadee approved these changes

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lchrusciel @pamil @GSadee @Tomanhez