Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change on from string to array, consistent with other definitions #12611

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

stefandoorn
Copy link
Contributor

Q A
Branch? 1.8
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

Nothing major, but the command bin/console debug:winzou:state-machine sylius_shipment errors due to a parsing bug in the underlying bundle. But next to that, this way is inconsistent with Sylius docs & the declaration below, so I think it's still good to adjust this in Sylius also.

@stefandoorn stefandoorn requested a review from a team as a code owner May 7, 2021 09:45
@Zales0123
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "winzou" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@Zales0123 Zales0123 changed the base branch from 1.8 to 1.11 November 7, 2022 07:11
@Zales0123 Zales0123 added the DX Issues and PRs aimed at improving Developer eXperience. label Nov 7, 2022
@Zales0123 Zales0123 merged commit 04665a1 into Sylius:1.11 Nov 7, 2022
@Zales0123
Copy link
Member

Thanks, Stefan! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants