[CatalogPromotion][API] Add channels to catalog promotion #13009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Aug 26, 2021
GSadee
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
Arminek
approved these changes
Aug 26, 2021
AdamKasp
approved these changes
Aug 26, 2021
|
Thank you, Grzegorz! 🥇 |
AdamKasp
added a commit
that referenced
this pull request
Sep 10, 2021
…per channels (GSadee) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | #13009 | License | MIT <!-- - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- f438c80 [CatalogPromotion][API] Add scenarios for applying catalog promotion in proper channels 6ffdba1 [CatalogPromotion][API] Improve and implement scenarios for applying catalog promotion in proper channels bda8906 [CatalogPromotion][API] Apply catalog promotion in proper channels 8f3c9d1 [CatalogPromotion][Behat] Remove unused step definition 8305c48 [CatalogPromotion][Fixtures] Remove unnecessary normalizing rules and actions in example factory
AdamKasp
added a commit
to Sylius/SyliusCoreBundle
that referenced
this pull request
Sep 10, 2021
…per channels (GSadee) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | Sylius/Sylius#13009 | License | MIT <!-- - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- f438c80efcd7751fa80addb52cc9ca3de1227c18 [CatalogPromotion][API] Add scenarios for applying catalog promotion in proper channels 6ffdba14b29013c9292083cea4770e79d3211a6f [CatalogPromotion][API] Improve and implement scenarios for applying catalog promotion in proper channels bda8906104d790c2aca2ef12a2be80105a8a14ab [CatalogPromotion][API] Apply catalog promotion in proper channels 8f3c9d1187dcf1ff17d1874219f99b142dd1fdf5 [CatalogPromotion][Behat] Remove unused step definition 8305c485a38ab44e2581e92ac3d606e79d574a68 [CatalogPromotion][Fixtures] Remove unnecessary normalizing rules and actions in example factory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.