[CatalogPromotion] refactor cp rule to be consistent with cp action #13066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SirDomin
commented
Sep 7, 2021
SirDomin
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
SirDomin
added
the
Enhancement
arti0090
approved these changes
Sep 7, 2021
src/Sylius/Bundle/PromotionBundle/Form/Type/CatalogRule/VariantRuleConfigurationType.php
Outdated
Show resolved
Hide resolved
lchrusciel
reviewed
Sep 7, 2021
src/Sylius/Bundle/PromotionBundle/Form/Type/CatalogRule/VariantRuleConfigurationType.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Resources/config/services/form.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Form/Extension/CatalogPromotionRuleTypeExtension.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/PromotionBundle/Form/Type/CatalogRule/VariantRuleConfigurationType.php
Outdated
Show resolved
Hide resolved
GSadee
reviewed
Sep 8, 2021
src/Sylius/Bundle/CoreBundle/Validator/Constraints/CatalogPromotionRulesValidator.php
Outdated
Show resolved
Hide resolved
SirDomin
force-pushed
the
rules-config-unification
branch
from
17259e3 to
29dfab7
Compare
GSadee
reviewed
Sep 8, 2021
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Sylius\Bundle\CoreBundle\Form\Type\CatalogRule; |
There was a problem hiding this comment.
Suggested change
| namespace Sylius\Bundle\CoreBundle\Form\Type\CatalogRule; | |
| namespace Sylius\Bundle\CoreBundle\Form\Type\CatalogPromotionRule; |
| use Symfony\Component\Form\DataTransformerInterface; | ||
| use Symfony\Component\Form\FormBuilderInterface; | ||
|
|
||
| final class VariantRuleConfigurationType extends AbstractType |
There was a problem hiding this comment.
Suggested change
| final class VariantRuleConfigurationType extends AbstractType | |
| final class ForVariantsRuleConfigurationType extends AbstractType |
GSadee
approved these changes
Sep 8, 2021
|
Thank you, @SirDomin! 🥇 |
lchrusciel
added a commit
that referenced
this pull request
Sep 8, 2021
…talog promotion rule form types (GSadee) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | after #13066 (review) | License | MIT <!-- - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- ba06dfe [CatalogPromotion] Improve names and namespaces of catalog promotion rule form types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.