[CatalogPromotion][UI] Reapply catalog promotions after product's taxon changes + refactor #13181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Oct 8, 2021
GSadee
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
…tions after scopes change
…ions after product's taxon changes
…product's taxon changes + refactor
GSadee
force-pushed
the
api-reapplying-catalog-promotions-taxons
branch
from
662b57e to
566d466
Compare
Zales0123
reviewed
Oct 8, 2021
src/Sylius/Bundle/CoreBundle/Listener/ProductVariantUpdateListener.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Processor/ProductCatalogPromotionsProcessor.php
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Page/Admin/Product/UpdateSimpleProductPage.php
Outdated
Show resolved
Hide resolved
Zales0123
approved these changes
Oct 8, 2021
|
Thank you, Grzegorz! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.