Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Disable session storage for autocomplete dropdowns #13573

Merged
merged 1 commit into from
Jun 21, 2022
Merged

[UI] Disable session storage for autocomplete dropdowns #13573

merged 1 commit into from
Jun 21, 2022

Conversation

benjamin-vauchel
Copy link

Q A
Branch? 1.10
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #13571
License MIT

@benjamin-vauchel benjamin-vauchel requested a review from a team as a code owner January 31, 2022 16:06
@lchrusciel lchrusciel changed the base branch from 1.10 to 1.11 June 21, 2022 10:59
@lchrusciel
Copy link
Member

Hey Benjamin,

thanks a lot for the details bug report and provided fix. Normally, we would love to see a test as well, but it may be cumbersome for this case. I've reproduced it locally and checked the fix.

Welcome to our community!

@GSadee GSadee added UX Issues and PRs aimed at improving User eXperience. Bug Confirmed bugs or bugfixes. labels Jun 21, 2022
@GSadee GSadee merged commit 57464b8 into Sylius:1.11 Jun 21, 2022
@GSadee
Copy link
Member

GSadee commented Jun 21, 2022

Thank you, Benjamin! 🥇

@Zales0123 Zales0123 mentioned this pull request Jun 22, 2022
Merged
lchrusciel added a commit that referenced this pull request Jun 22, 2022
@lchrusciel
bug #14105 Fix @javascript scenarios about channels menu taxon (Zales…
5f0f601 
…0123)

This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.11  |
| Bug fix?        | yes                                                       |
| New feature?    | no                                                       |
| BC breaks?      | no                                                       |
| Deprecations?   | no |
| Related tickets |  |
| License         | MIT                                                          |

After #13573 our Behat scenarios were too fast 🐎 and the value of the menu taxon is not loaded yet when it\'s checked. This quick fix should remove the issue.


Commits
-------

92656a8 Fix @javascript scenarios about channels menu taxon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes. UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjamin-vauchel @lchrusciel @GSadee