Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ScopeValidatorInterface to PromotionBundle #13627

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

Zales0123
Copy link
Member

Q A
Branch? 1.11
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

The interface has nothing in common with products or variants and is a contract directly coupled with catalog promotions concept 🚀

@Zales0123 Zales0123 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). DX Issues and PRs aimed at improving Developer eXperience. Bug Confirmed bugs or bugfixes. labels Feb 9, 2022
@Zales0123 Zales0123 requested a review from a team as a code owner February 9, 2022 15:20
@Zales0123 Zales0123 force-pushed the move-scope-validator-interface branch from 033a6af to eb05e0a Compare February 9, 2022 23:08
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Feb 9, 2022
@GSadee GSadee changed the base branch from master to 1.11 February 10, 2022 09:24
@GSadee
Copy link
Member

GSadee commented Feb 10, 2022

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "move-scope-validator-interface" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@GSadee GSadee force-pushed the move-scope-validator-interface branch from eb05e0a to 7e2c8c3 Compare February 10, 2022 09:24
@Zales0123 Zales0123 force-pushed the move-scope-validator-interface branch from 7e2c8c3 to ee8f8b9 Compare February 10, 2022 10:59
@GSadee GSadee force-pushed the move-scope-validator-interface branch 2 times, most recently from 89ad10e to 9971a48 Compare February 10, 2022 12:05
@Zales0123 Zales0123 force-pushed the move-scope-validator-interface branch from 3827bde to 5219ec6 Compare February 10, 2022 12:48
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Feb 10, 2022
@GSadee GSadee merged commit fd5085a into Sylius:1.11 Feb 10, 2022
@GSadee
Copy link
Member

GSadee commented Feb 10, 2022

Thank you, Mateusz! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs. Bug Confirmed bugs or bugfixes. Documentation Documentation related issues and PRs - requests, fixes, proposals. DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants