Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI][CatalogPromotion] Fix to not displaying duplicated validation message for fixed discount action #13639

Merged
merged 1 commit into from
Feb 11, 2022
Merged

[UI][CatalogPromotion] Fix to not displaying duplicated validation message for fixed discount action #13639

merged 1 commit into from
Feb 11, 2022

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Feb 11, 2022

Q A
Branch? 1.11
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Before:
image

After:
image

@GSadee GSadee added UX Issues and PRs aimed at improving User eXperience. Admin AdminBundle related issues and PRs. labels Feb 11, 2022
@GSadee GSadee requested a review from a team as a code owner February 11, 2022 07:25
@GSadee GSadee added the Bug Confirmed bugs or bugfixes. label Feb 11, 2022
Zales0123
Zales0123 approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it's not a real not blank - but a conditional not blank that is only required if the channel is enabled 👌

@Zales0123 Zales0123 merged commit d0ef36b into Sylius:1.11 Feb 11, 2022
@Zales0123
Copy link
Member

Thank you, Grzegorz! 🎉

@GSadee GSadee deleted the ui-catalog-promotion-actions-fixes branch February 11, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamKasp AdamKasp AdamKasp approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. Bug Confirmed bugs or bugfixes. UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GSadee @Zales0123 @AdamKasp