Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dependency injection conflict #13715

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Conversation

SirDomin
Copy link
Contributor

Q A
Branch? 1.10
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@SirDomin SirDomin requested a review from a team as a code owner February 28, 2022 15:02
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Feb 28, 2022
@SirDomin SirDomin changed the title [WIP] add dependency injection conflict add dependency injection conflict Feb 28, 2022
@Zales0123 Zales0123 merged commit f355df2 into Sylius:1.10 Feb 28, 2022
@Zales0123
Copy link
Member

Thanks, @SirDomin! 🎉


These versions are causing a problem with mink session:
`InvalidArgumentException: Specify session name to get in vendor/friends-of-behat/mink/src/Mink.php:198`,
Psalm error:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one really should be dealt with in the Sylius Psalm config, the test environment bug is a big thing to conflict against but this one really needs an application-level fix. See symfony/symfony#45627 and vimeo/psalm#7703 for more context.

lchrusciel added a commit that referenced this pull request Mar 7, 2022
…more (Zales0123)

This PR was merged into the 1.10 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.10
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | 
| License         | MIT

Definitely still not a proper solution (#13715 was not one either), but a hot-fix for making the build 🟢 again 🖖 

Commits
-------

ac527ae [Fix Build] Conflict with symfony/dependency-injection even more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants