Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Promotion] Add validation of coupon usage limit per customer #13745

Merged
merged 4 commits into from
Mar 14, 2022
Merged

[Promotion] Add validation of coupon usage limit per customer #13745

merged 4 commits into from
Mar 14, 2022

Conversation

coldic3
Copy link
Contributor

@coldic3 coldic3 commented Mar 9, 2022

Q A
Branch? 1.10
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@coldic3 coldic3 requested a review from a team as a code owner March 9, 2022 11:16
@coldic3 coldic3 force-pushed the fix/negative-coupons branch from 2f18347 to de5a54c Compare March 9, 2022 13:46
@coldic3 coldic3 force-pushed the fix/negative-coupons branch from de5a54c to 446c8d1 Compare March 14, 2022 06:52
@coldic3 coldic3 force-pushed the fix/negative-coupons branch from 446c8d1 to b7894fd Compare March 14, 2022 08:15
@coldic3
[Promotion][Behat] Update coupon validation feature
10e1773 
[Promotion][Behat] Fix return type
@coldic3 coldic3 force-pushed the fix/negative-coupons branch from b7894fd to 10e1773 Compare March 14, 2022 08:35
@lchrusciel lchrusciel added Admin AdminBundle related issues and PRs. Bug Confirmed bugs or bugfixes. labels Mar 14, 2022
@lchrusciel lchrusciel merged commit 591389f into Sylius:1.10 Mar 14, 2022
@lchrusciel
Copy link
Member

Thank you, Kevin! 🥇

@coldic3 coldic3 deleted the fix/negative-coupons branch March 14, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamKasp AdamKasp AdamKasp approved these changes

@Roshyo Roshyo Roshyo approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coldic3 @lchrusciel @Roshyo @AdamKasp