[API] Extract user logic rules for orders to separate extension #13984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lchrusciel
commented
May 13, 2022
lchrusciel
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | Continues #13962 |
| License | MIT |
lchrusciel
force-pushed
the
order-extensions-refactor
branch
from
f9c962a to
d57c018
Compare
lchrusciel
changed the title
lchrusciel
force-pushed
the
order-extensions-refactor
branch
from
d57c018 to
e83f422
Compare
AdamKasp
approved these changes
May 16, 2022
lchrusciel
force-pushed
the
order-extensions-refactor
branch
from
e83f422 to
cd256c7
Compare
GSadee
approved these changes
May 18, 2022
Comment on lines
+44
to
+49
| $rootAlias = $queryBuilder->getRootAliases()[0]; | ||
| $user = $this->userContext->getUser(); | ||
|
|
||
| if (!$user instanceof ShopUserInterface) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Suggested change
| $rootAlias = $queryBuilder->getRootAliases()[0]; | |
| $user = $this->userContext->getUser(); | |
| if (!$user instanceof ShopUserInterface) { | |
| return; | |
| } | |
| $user = $this->userContext->getUser(); | |
| if (!$user instanceof ShopUserInterface) { | |
| return; | |
| } | |
| $rootAlias = $queryBuilder->getRootAliases()[0]; |
Comment on lines
+43
to
+49
| $rootAlias = $queryBuilder->getRootAliases()[0]; | ||
|
|
||
| $user = $this->userContext->getUser(); | ||
|
|
||
| if ($user !== null) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Suggested change
| $rootAlias = $queryBuilder->getRootAliases()[0]; | |
| $user = $this->userContext->getUser(); | |
| if ($user !== null) { | |
| return; | |
| } | |
| $user = $this->userContext->getUser(); | |
| if ($user !== null) { | |
| return; | |
| } | |
| $rootAlias = $queryBuilder->getRootAliases()[0]; |
| ); | ||
| } | ||
|
|
||
| function it_does_nothing_if_object_passed_is_different_then_order( |
There was a problem hiding this comment.
Suggested change
| function it_does_nothing_if_object_passed_is_different_then_order( | |
| function it_does_nothing_if_object_passed_is_different_than_order( |
| $this->beConstructedWith($userContext); | ||
| } | ||
|
|
||
| function it_filters_carts_for_visitors_to_not_authorized_for_methods_other_then_get( |
There was a problem hiding this comment.
Suggested change
| function it_filters_carts_for_visitors_to_not_authorized_for_methods_other_then_get( | |
| function it_filters_carts_for_visitors_to_not_authorized_for_methods_other_than_get( |
| $this->beConstructedWith($userContext); | ||
| } | ||
|
|
||
| function it_filters_carts_for_shop_users_to_the_one_owned_by_them_for_methods_other_then_get( |
There was a problem hiding this comment.
Suggested change
| function it_filters_carts_for_shop_users_to_the_one_owned_by_them_for_methods_other_then_get( | |
| function it_filters_carts_for_shop_users_to_the_one_owned_by_them_for_methods_other_than_get( |
| ); | ||
| } | ||
|
|
||
| function it_does_nothing_if_object_passed_is_different_then_order( |
There was a problem hiding this comment.
Suggested change
| function it_does_nothing_if_object_passed_is_different_then_order( | |
| function it_does_nothing_if_object_passed_is_different_than_order( |
|
Thank you, Łukasz! 🎉 |
GSadee
added a commit
that referenced
this pull request
Feb 3, 2023
…ciel, jakubtobiasz) This PR was merged into the 1.12 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | master | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Related tickets | #13984 (review) | | License | MIT | <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 25fd428 [Minor] Typo fixes and small code improvement ed00a4e Fix wrongly placed changes
GSadee
added a commit
to Sylius/SyliusApiBundle
that referenced
this pull request
Feb 13, 2023
…ciel, jakubtobiasz) This PR was merged into the 1.12 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | master | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Related tickets | Sylius/Sylius#13984 (review) | | License | MIT | <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 25fd428c3f1d7689617148c7eed7cd69583b53d7 [Minor] Typo fixes and small code improvement ed00a4e474c271c4399b66aaab974ed3541ad7c5 Fix wrongly placed changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.