Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix calculate order item subtotal #14090

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Fix calculate order item subtotal #14090

merged 2 commits into from
Jun 22, 2022

Conversation

AdamKasp
Copy link
Contributor

@AdamKasp AdamKasp commented Jun 17, 2022 •
edited
Loading

Q A
Branch? 1.11
Bug fix? yes
New feature? no
Related tickets replace #13986, fixes #13532 and #11585
License MIT

We also should add here behat scenario, but TBH, I don't know how to prepare proper background

@AdamKasp AdamKasp force-pushed the fix-calculate-order-item-subtotal branch 3 times, most recently from c9d1dfb to 9ac75fd Compare June 18, 2022 10:32
@AdamKasp AdamKasp changed the title [WIP] Fix calculate order item subtotal Fix calculate order item subtotal Jun 18, 2022
@AdamKasp AdamKasp marked this pull request as ready for review June 18, 2022 10:32
@AdamKasp AdamKasp requested a review from a team as a code owner June 18, 2022 10:32
@vvasiloi
Copy link
Contributor

Is this meant to replace #13986?

@AdamKasp
Copy link
Contributor Author

AdamKasp commented Jun 20, 2022 •
edited
Loading

Is this meant to replace #13986?

yes, the description has been updated

@vvasiloi vvasiloi mentioned this pull request Jun 20, 2022
Closed
@AdamKasp AdamKasp force-pushed the fix-calculate-order-item-subtotal branch from 9ac75fd to c29c14c Compare June 22, 2022 08:18
@GSadee GSadee added the Bug Confirmed bugs or bugfixes. label Jun 22, 2022
@AdamKasp AdamKasp force-pushed the fix-calculate-order-item-subtotal branch from c29c14c to 83009ce Compare June 22, 2022 09:34
@GSadee GSadee force-pushed the fix-calculate-order-item-subtotal branch from 83009ce to b987eee Compare June 22, 2022 18:32
@GSadee GSadee merged commit 472e03f into Sylius:1.11 Jun 22, 2022
@GSadee
Copy link
Member

GSadee commented Jun 22, 2022

Thanks, Adam! 🥇

@AdamKasp AdamKasp deleted the fix-calculate-order-item-subtotal branch June 23, 2022 05:33
@NoResponseMate NoResponseMate mentioned this pull request Jun 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdamKasp @vvasiloi @GSadee