[Maintenance] Introduce Flysystem and use it in place of Gaufrette by default #14298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
Admin
coldic3
force-pushed
the
feature/introduce-flysystem
branch
3 times, most recently
from
c955638 to
325b4d7
Compare
coldic3
force-pushed
the
feature/introduce-flysystem
branch
from
860075f to
14dd51f
Compare
probot-autolabeler
bot
added
Maintenance
coldic3
force-pushed
the
feature/introduce-flysystem
branch
2 times, most recently
from
5ecd65a to
3294afd
Compare
Co-authored-by: Jakub Tobiasz <[email protected]>
…mInterface in ImageUploader
coldic3
force-pushed
the
feature/introduce-flysystem
branch
from
3294afd to
ef19593
Compare
coldic3
commented
Sep 15, 2022
| FilesystemAdapterInterface::class, | ||
| match($config['filesystem']['adapter']) { | ||
| 'default', 'flysystem' => FlysystemFilesystemAdapter::class, | ||
| 'gaufrette' => 'Sylius\Component\Core\Filesystem\Adapter\GaufretteFilesystemAdapter', |
There was a problem hiding this comment.
Because /** @psalm-suppress DeprecatedClass */ doesn't work for the ::class constant :/
coldic3
force-pushed
the
feature/introduce-flysystem
branch
from
d1f500e to
d95310a
Compare
coldic3
force-pushed
the
feature/introduce-flysystem
branch
from
d95310a to
b960b05
Compare
lchrusciel
reviewed
Sep 19, 2022
src/Sylius/Component/Core/Filesystem/Adapter/GaufretteFilesystemAdapter.php
Outdated
Show resolved
Hide resolved
src/Sylius/Component/Core/spec/Filesystem/Adapter/FlysystemFilesystemAdapterSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Component/Core/spec/Filesystem/Adapter/FlysystemFilesystemAdapterSpec.php
Show resolved
Hide resolved
src/Sylius/Component/Core/spec/Filesystem/Adapter/GaufretteFilesystemAdapterSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Component/Core/Filesystem/Adapter/FlysystemFilesystemAdapter.php
Outdated
Show resolved
Hide resolved
coldic3
force-pushed
the
feature/introduce-flysystem
branch
from
884b0af to
704aeda
Compare
NoResponseMate
approved these changes
Sep 19, 2022
| @@ -29,7 +29,7 @@ references related issues. | |||
| This version contains service with a wrong constructor arguments: | |||
| `Invalid definition for service ".container.private.profiler": argument 4 of "JMS\SerializerBundle\Debug\DataCollector::__construct()" accepts "JMS\SerializerBundle\Debug\TraceableDriver", "JMS\SerializerBundle\Debug\TraceableMetadataFactory" passed.` | |||
|
|
|||
| References: https://github.com/schmittjoh/JMSSerializerBundle/issues/844 | |||
lchrusciel
reviewed
Sep 19, 2022
src/Sylius/Bundle/CoreBundle/DependencyInjection/SyliusCoreExtension.php
Show resolved
Hide resolved
NoResponseMate
removed
Admin
NoResponseMate
added a commit
that referenced
this pull request
Oct 4, 2022
…e upgrade file (coldic3) This PR was merged into the 1.12 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.12 | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Related tickets | #14298 | | License | MIT | Commits ------- 37cd6c0 [Maintenance] Mention Gaufrette filesystem adapter in the upgrade file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Gaufrette becomes deprecated in favor of Flysystem.