Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add repository option to product_image node #14563

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Add repository option to product_image node #14563

merged 1 commit into from
Nov 23, 2022

Conversation

TheMilek
Copy link
Member

@TheMilek TheMilek commented Nov 20, 2022 •
edited
Loading

Q A
Branch? 1.11
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #X
License MIT

@TheMilek TheMilek changed the base branch from 1.13 to 1.12 November 20, 2022 22:28
@TheMilek TheMilek marked this pull request as ready for review November 20, 2022 22:28
@TheMilek TheMilek requested a review from a team as a code owner November 20, 2022 22:28
GSadee
GSadee reviewed Nov 21, 2022
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be for adding this to the 1.11 branch

@TheMilek TheMilek changed the base branch from 1.12 to 1.11 November 21, 2022 08:23
@TheMilek TheMilek force-pushed the add-missing-option-to-node branch from 92be4a4 to 8a39291 Compare November 21, 2022 08:24
@TheMilek TheMilek force-pushed the add-missing-option-to-node branch 3 times, most recently from b62e9ae to 7b0948b Compare November 22, 2022 00:04
@TheMilek TheMilek force-pushed the add-missing-option-to-node branch from 7b0948b to bf4240a Compare November 22, 2022 08:15
@GSadee GSadee merged commit aeb37ae into Sylius:1.11 Nov 23, 2022
@GSadee
Copy link
Member

GSadee commented Nov 23, 2022

Thank you, Kamil! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coldic3 coldic3 coldic3 approved these changes

@NoResponseMate NoResponseMate NoResponseMate approved these changes

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to add custom repository for ProductImage
4 participants
@TheMilek @GSadee @NoResponseMate @coldic3