Remove duplicated ClassAttributesSeparationFixer and use default config #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loevgaard
added a commit
to Setono/code-quality-pack
that referenced
this pull request
Aug 2, 2021
|
@pamil 🙏🏻 |
|
I did the same in #41, but this one looks better to me. @Zales0123 @pamil could you have a look? |
|
@pamil could you merge it? |
|
Thank you, Luca! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry but there was an error in the previous PR. The ClassAttributesSeparationFixer is specified twice and the upgrade.md file was misleading:
['elements' => ['method']]is not a valid config for this fixer.Btw the default config is ok https://cs.symfony.com/doc/rules/class_notation/class_attributes_separation.html so we can avoid to specify a custom configuration for this fixer.