Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict against newer ECS 10.x releases due to exception causing hard fail #48

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Jun 14, 2022

In deprecated-packages/symplify@9d1b0ea (released with 10.2.11), the warning message about the deprecated config syntax was changed from printing a warning to throwing an exception. This effectively means that using ECS >=10.2.11,<11.0 with the ContainerConfigurator based configuration is impossible as the ECS application doesn't handle this exception which causes it to abort. Since this package doesn't yet provide an ECSConfig based configuration, conflicting against newer 10.x releases is the only sane option until the newer syntax is supported.

Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 although we should definitely switch to the new configuration standard 🖖

@Zales0123 Zales0123 merged commit a1d2381 into SyliusLabs:master Jun 15, 2022
@Zales0123
Copy link
Member

Thank you, Michael! 🎉

@mbabker mbabker deleted the patch-1 branch June 15, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants