Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and improve README #56

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Fix and improve README #56

merged 1 commit into from
Jun 9, 2023

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented May 19, 2023 •
edited
Loading

szepeviktor
szepeviktor commented May 19, 2023
View reviewed changes
README.md
Comment on lines -13 to +12
$ composer require --dev sylius-labs/coding-standard
composer require --dev sylius-labs/coding-standard
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this copyable.

szepeviktor
szepeviktor commented May 19, 2023
View reviewed changes
README.md
Comment on lines -25 to +29
```php
use Symplify\EasyCodingStandard\Config\ECSConfig;;
return static function (ECSConfig $ecsConfig): void {
$ecsConfig->import('vendor/sylius-labs/coding-standard/ecs.php');
};
```
```php
use Symplify\EasyCodingStandard\Config\ECSConfig;

return static function (ECSConfig $ecsConfig): void {
$ecsConfig->import(__DIR__ . '/vendor/sylius-labs/coding-standard/ecs.php');
};
```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix Markdown

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and use absolute paths

@GSadee GSadee merged commit fb248de into SyliusLabs:master Jun 9, 2023
@GSadee
Copy link
Member

GSadee commented Jun 9, 2023

Thanks, Viktor! 🥇

@szepeviktor szepeviktor deleted the patch-1 branch June 9, 2023 05:34
@szepeviktor
Copy link
Contributor Author

You're welcome.

@szepeviktor
Copy link
Contributor Author

It was fun to explore your bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coldic3 coldic3 coldic3 approved these changes

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szepeviktor @GSadee @coldic3