Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flogo webui reports successful install when logs show fail #195

Closed
btrepp opened this issue Mar 20, 2018 · 2 comments
Closed

Flogo webui reports successful install when logs show fail #195

btrepp opened this issue Mar 20, 2018 · 2 comments

Comments

@btrepp
Copy link

btrepp commented Mar 20, 2018

flogogen activity Test
cd Test
git init .
git commit -am "Initial"
git remote add origin "someurl"
git push

Flogo webui -> install activity
User interface reports success, but nothing is in the activity list

Logs show

[log] Install Activities
[ 'https://internalgit/flogo-test.git' ]
[log] adding activities to test engine...
[info] Stop engine PID: 487, COMMAND: ./flogo-web, ARGUMENTS:
[info] Stop engine Process 487 has been killed!
[log] Install from GitHub
[]
[log] Installed
[TODO] Default installation
[TODO defaultInstall] Try to install [https://internalgit/flogo-test.git]..
2018-03-20T02:16:43.554Z - info: Exec command: flogo list -json in local/engines/flogo-web
2018-03-20T02:16:43.559Z - info: run command: flogo list -json
local/engines/flogo-web/src/flogo-web/vendor?:  false
local/engines/flogo-web/vendor/src?:  false
2018-03-20T02:16:43.625Z - verbose: updateDB
2018-03-20T02:16:43.647Z - verbose: updateDB
2018-03-20T02:16:43.659Z - verbose: updateDB done.
2018-03-20T02:16:43.659Z - verbose: updateDB done.
2018-03-20T02:16:43.659Z - verbose: registerActivities success
2018-03-20T02:16:43.660Z - verbose: registerTriggers success
[log] Installation results
{ success: [],
  fail: [ 'https://internalgit/flogo-test.git' ] }
[log] Build flogo: "flogo build " compileOpts:
2018-03-20T02:16:43.666Z - info: run command: flogo build
[log] build output: /tmp/flogo-web/build/server/local/engines/flogo-web
github.com/TIBCOSoftware/flogo-contrib/activity/mapper
github.com/TIBCOSoftware/flogo-contrib/activity/log
github.com/TIBCOSoftware/flogo-contrib/activity/reply
github.com/TIBCOSoftware/flogo-contrib/activity/twilio
github.com/TIBCOSoftware/flogo-contrib/activity/rest
github.com/TIBCOSoftware/flogo-contrib/activity/wsmessage
github.com/TIBCOSoftware/flogo-contrib/trigger/cli
github.com/TIBCOSoftware/flogo-contrib/trigger/coap
github.com/TIBCOSoftware/flogo-contrib/trigger/lambda
github.com/TIBCOSoftware/flogo-contrib/trigger/kafkasub
github.com/TIBCOSoftware/flogo-contrib/trigger/mqtt
github.com/TIBCOSoftware/flogo-contrib/trigger/rest
github.com/TIBCOSoftware/flogo-contrib/activity/actreply
github.com/TIBCOSoftware/flogo-contrib/action/flow
github.com/TIBCOSoftware/flogo-contrib/activity/actreturn
github.com/TIBCOSoftware/flogo-contrib/activity/aggregate
github.com/TIBCOSoftware/flogo-contrib/activity/app
github.com/TIBCOSoftware/flogo-contrib/activity/awsiot
github.com/TIBCOSoftware/flogo-contrib/activity/coap
github.com/TIBCOSoftware/flogo-contrib/activity/couchbase
github.com/TIBCOSoftware/flogo-contrib/activity/counter
github.com/TIBCOSoftware/flogo-contrib/activity/error
github.com/TIBCOSoftware/flogo-contrib/activity/gpio
github.com/TIBCOSoftware/flogo-contrib/activity/kafkapub
github.com/TIBCOSoftware/flogo-contrib/activity/lambda
github.com/TIBCOSoftware/flogo-contrib/trigger/timer
flogo-web

[log] execName: flogo-web
[debug] Default compile, grab file directly
[info] starting engine flogo-web
[info] defaultEngineBinPath:  local/engines/flogo-web/bin-test
[DEBUG] Env for test runner (will be merged with the system env):
{ FLOGO_LOG_LEVEL: 'DEBUG',
  TESTER_ENABLED: 'true',
  TESTER_PORT: '8080',
  TESTER_SR_SERVER: '127.0.0.1:9190' }
2018-03-20T02:16:46.477Z - verbose: POST /v1/api/activities - 0
2018-03-20T02:16:46.479Z - verbose:  success=[], fail=[https://internalgit/flogo-test.git]
2018-03-20T02:16:46.480Z - verbose:  urls=[https://internalgit/flogo-test.git]
@mellistibco
Copy link
Collaborator

mellistibco commented Mar 20, 2018

The ui shouldn't report it as a success if it isn't, but the activity produced by flogogen will require some edits before you can install it, specifically the ref attribute in activity.json, this should be the git location of the activity. For example, the rest activity has:

"ref": "github.com/TIBCOSoftware/flogo-contrib/activity/rest",

@btrepp
Copy link
Author

btrepp commented Mar 20, 2018

I'm happy to accept that my activity is invalid. Was more surprised it said everything was okay!

The default activity.json doesn't seem to include "ref". (from flogogen activity)

{                                                            
  "name": "Test",                                             
  "version": "0.0.1",                                        
  "type": "flogo:activity",                                  
  "description": "activity description",                     
  "author": "Your Name <[email protected]>",              
  "inputs":[                                                 
    {                                                        
      "name": "input",                                       
      "type": "string"                                       
    }                                                        
  ],                                                         
  "outputs": [                                               
    {                                                        
      "name": "output",                                      
      "type": "string"                                       
    }                                                        
  ]                                                          
}                                                            

https://tibcosoftware.github.io/flogo/development/extensions/building-your-first-activity/ doesn't mention ref either :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants