Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance support for Application Properties #226

Closed
vijaynalawade opened this issue Apr 10, 2018 · 5 comments
Closed

Enhance support for Application Properties #226

vijaynalawade opened this issue Apr 10, 2018 · 5 comments
Assignees
Milestone

Comments

@vijaynalawade
Copy link
Contributor

I'm submitting a ... (check one with "x")

[] bug report => search github for a similar issue or PR before submitting
[x] feature request
[] support request
[] general question

Current behavior (how does the issue manifest):
Currently, there is no support for property type or grouping of properties.
Expected behavior:
Users should be able to set a type as well able to group set of properties together.
Minimal steps to reproduce the problem (not required if feature enhancement):

What is the motivation / use case for changing the behavior?
https://github.com/TIBCOSoftware/flogo/wiki/Application-Properties
Please tell us about your environment (Operating system, docker version, browser & web ui version, etc):

Flogo version (CLI & contrib/lib. If unknown, leave empty or state unknown): 0.X.X

Additional information you deem important (e.g. issue happens only occasionally):

@vijaynalawade vijaynalawade changed the title Enhance Application Properties Enhance support for Application Properties Apr 10, 2018
@retgits
Copy link
Contributor

retgits commented Apr 10, 2018

I like the idea! One small question though, in one of the code blocks you're referring to $env[ENV_DB_URL] while today that would be $env.ENV_DB_URL. Do we expect to change that too and if so, will it be backward compatible with the existing apps?

@vijaynalawade
Copy link
Contributor Author

vijaynalawade commented Apr 10, 2018

@retgits Thats proposed change for consistency with $property and $activity. Though supported for few releases, we will deprecate use of $env.<NAME> in the future.

@ayh20
Copy link
Contributor

ayh20 commented Apr 11, 2018

are you talking about deprecating $env completely ? or just the $env.ENV_VAR syntax ?

@mellistibco
Copy link
Collaborator

@ayh20 just changing the syntax. so we'll make the switch to $env[ENV_DB_URL] and support the syntax of $env.ENV_DB_URL and $env[ENV_DB_URL] for a period of time.

@mellistibco mellistibco added this to the 0.5.4 milestone Apr 13, 2018
@mellistibco
Copy link
Collaborator

Resolved in TIBCOSoftware/flogo-lib#171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants