Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expect proper error message to user: Flogo FAAS #286

Closed
debikadutt opened this issue May 31, 2018 · 2 comments
Closed

Expect proper error message to user: Flogo FAAS #286

debikadutt opened this issue May 31, 2018 · 2 comments
Assignees
Milestone

Comments

@debikadutt
Copy link

I'm submitting a ... (check one with "x")

[] bug report => search github for a similar issue or PR before submitting
[x] feature request
[] support request
[] general question

Current behavior (how does the issue manifest):
While working on deploying my app to AWS lambda I came across this issue: if my trigger ID in my json does not match the one which I supply to the CLI to create the zip file flogo build -e -TRIGGER_ID then the error shown to the user is a vague one and can be made more specific to let the user know about his mistake. The error currently shown is "Shim Metadata lambda runtime.main_main·f: relocation target main.main not defined runtime.main_main·f: undefined: "main.main" FATAL: command "build" failed: exit status 2"

Expected behavior:
A more informative error message

Minimal steps to reproduce the problem (not required if feature enhancement):
Passing a different trigger_id to the above command other than the one in your json file.

What is the motivation / use case for changing the behavior?

Please tell us about your environment (Operating system, docker version, browser & web ui version, etc):
Windows 10, Flogo Web UI 0.5.4

Flogo version (CLI & contrib/lib. If unknown, leave empty or state unknown): 0.X.X
Flogo Web UI 0.5.4

Additional information you deem important (e.g. issue happens only occasionally):

@retgits
Copy link
Contributor

retgits commented Jun 1, 2018

Thanks for suggesting this enhancement! We've updated the flogo-cli to give a proper message if the id of the trigger doesn't exist. In such a case you'll see a message like:

$ flogo build -e -shim my_lambda_trigger
Shim: my_lambda_trigger

Can't locate trigger with id [my_lambda_trigger] in flogo.json
Please check if you have specified the correct trigger id

You can get the latest version of the cli by running:

$ go get -u github.com/TIBCOSoftware/flogo-cli

@retgits retgits closed this as completed Jun 1, 2018
@debikadutt
Copy link
Author

Great! Thanks.

@mellistibco mellistibco added this to the 0.5.5 milestone Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants