New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This won't work on non macos systems #158

Open

pakettiale opened this issue Aug 24, 2023 · 1 comment

Collaborator

pakettiale commented Aug 24, 2023

full-stack-template/client/src/components/feature-flags/FeatureFlagManager.tsx

Line 21 in c071d95

useShortcut('Meta+K', () => {

At least firefox on linux reports Control instead of Meta

pakettiale changed the title ~~This won't work in non mac~~ This won't work on non macos systems

Collaborator Author

pakettiale commented Aug 24, 2023

https://github.com/TaitoUnited/full-stack-template/blob/c071d951aae7fba4210d1aae23d595c93ca663f2/client/src/utils/observe.ts#L63C16-L63C16

instead of this we can check altKey, ctrlKey, metaKey fields from the key event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment