Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sending GET request to missing crate download endpoint returns 405 (Method not allowed) #15

Closed
rluvaton opened this issue Aug 1, 2024 · 0 comments
Closed

sending GET request to missing crate download endpoint returns 405 (Method not allowed) #15

rluvaton opened this issue Aug 1, 2024 · 0 comments

Comments

@rluvaton
Copy link
Contributor

rluvaton commented Aug 1, 2024

According to "The Cargo Book"

For crates that do not exist, the registry should respond with a 404 “Not Found”, 410 “Gone” or 451 “Unavailable For Legal Reasons” code.

From Cargo book

(I'll send PR shortly)
rluvaton added a commit to rluvaton/crates-registry that referenced this issue Aug 1, 2024
@rluvaton
Fix GET /download missing crate return 405 (Fix TalRoni#15)
0636110
@rluvaton rluvaton mentioned this issue Aug 1, 2024
Closed
rluvaton added a commit to rluvaton/crates-registry that referenced this issue Aug 4, 2024
@rluvaton
Fix GET /download missing crate return 405 (Fix TalRoni#15)
be9ea06
@rluvaton rluvaton mentioned this issue Aug 4, 2024
Merged
@TalRoni TalRoni closed this as completed in c7b6a86 Aug 5, 2024
TalRoni pushed a commit that referenced this issue Sep 23, 2024
@rluvaton
Add HEAD support to download and publish (#14) (#19)
d34fd04 
* Fix GET /download missing crate return 405 (Fix #15)

* keep only relevant changes

* keep only relevant

* Add head to download route

* added support for publish as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rluvaton