Jill(feat) use tertiary button for date and navigation button in date picker #2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
jillyan
changed the title
1 similar comment
yyanwang
approved these changes
Sep 12, 2019
jsomsanith-tlnd
suggested changes
Sep 17, 2019
packages/components/src/DateTimePickers/pickers/DatePicker/DatePicker.scss
Show resolved
Hide resolved
packages/components/src/DateTimePickers/views/DateTimeView/DateTimeView.component.js
Show resolved
Hide resolved
packages/components/src/DateTimePickers/views/DateTimeView/DateTimeView.component.js
Show resolved
Hide resolved
packages/components/src/DateTimePickers/views/HeaderTitle/HeaderTitle.scss
Show resolved
Hide resolved
packages/components/src/DateTimePickers/views/MonthYearView/MonthYearView.component.js
Show resolved
Hide resolved
| @@ -6,16 +6,18 @@ | |||
|
|
|||
| .header { | |||
| display: flex; | |||
| height: 5rem; | |||
| height: 2.5rem; | |||
There was a problem hiding this comment.
You should not set a height.
In the header, define the paddings only (as described in the guideline). The height will be set automatically depending on the paddings and the buttons height.
1 similar comment
jsomsanith-tlnd
approved these changes
Sep 18, 2019
jillyan
deleted the
jill/feat-TCCUI65-use-ghost-button-in-date-picker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
TCCUI-65 http://guidelines.talend.com/document/92132#/ui-controls/date-time-picker-1561102408
What is the chosen solution to this problem?
Use tertiary button for date.
Modify style for Today
Replace the navigation button icon by arrow( from chevron)
Please check if the PR fulfills these requirements
[ ] This PR introduces a breaking change