Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to allow the new version of the libraries #18

Merged
merged 5 commits into from
Feb 14, 2023
Merged

Updates to allow the new version of the libraries #18

merged 5 commits into from
Feb 14, 2023

Conversation

andreia
Copy link
Member

@andreia andreia commented Feb 13, 2023

Issue: #17

  • add the new signPartUpload method
  • remove prepareUploadParts method
  • refactor comments to docblock
  • add type hints
  • update README instructions to new version of the JS libraries

@andreia andreia requested a review from swilla February 13, 2023 01:54
@swilla swilla self-requested a review February 13, 2023 14:23
swilla
swilla requested changes Feb 13, 2023
View reviewed changes
Copy link
Member

@swilla swilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you see if you can fix some of the broken dependency checks on some of the versions in the matrix?

@andreia andreia merged commit 69a0243 into master Feb 14, 2023
@delete-merged-branch delete-merged-branch bot deleted the update_libraries branch February 14, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swilla swilla swilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreia @swilla