Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency meziantou.analyzer to v1.0.758 #524

Merged
merged 2 commits into from
Mar 25, 2024
Merged

chore(deps): update dependency meziantou.analyzer to v1.0.758 #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
331983c
chore(deps): update dependency meziantou.analyzer to v1.0.758
renovate[bot] Mar 25, 2024
69a13fd
Accept or fix additional warnings
vbreuss Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,3 +241,4 @@ dotnet_diagnostic.MA0005.severity = none
dotnet_diagnostic.MA0016.severity = none
dotnet_diagnostic.MA0048.severity = none
dotnet_diagnostic.MA0051.severity = none
dotnet_diagnostic.MA0099.severity = none
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@
<PackageVersion Include="Testably.Abstractions.FluentAssertions" Version="1.0.1" />
</ItemGroup>
<ItemGroup>
<PackageVersion Include="Meziantou.Analyzer" Version="1.0.570" />
<PackageVersion Include="Meziantou.Analyzer" Version="1.0.758" />
</ItemGroup>
</Project>
2 changes: 2 additions & 0 deletions Source/Testably.Abstractions.Testing/Polyfills/StringExtensionMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@ internal static string Replace(
string newValue,
StringComparison comparisonType)
{
#pragma warning disable MA0074
return @this.Replace(oldValue, newValue);
#pragma warning restore MA0074
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion Tests/Testably.Abstractions.Testing.Tests/FileSystemInitializer/DirectoryDescriptionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public void Children_ShouldBeSortedAlphabetically(string[] childNames)
.Cast<FileSystemInfoDescription>()
.ToArray());

sut.Children.Select(c => c.Name).Should().BeInAscendingOrder();
sut.Children.Select(c => c.Name).Should().BeInAscendingOrder(StringComparer.Ordinal);
}

[Fact]
Expand Down
4 changes: 2 additions & 2 deletions Tests/Testably.Abstractions.Testing.Tests/Helpers/RandomSystemExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public void GenerateRandomFileExtension_ShouldNotStartWithDotOrReturnEmptyString
while (true)
{
string fileExtension = randomSystem.Random.Shared.GenerateFileExtension();
if (fileExtensions.Contains(fileExtension))
if (fileExtensions.Contains(fileExtension, StringComparer.Ordinal))
{
break;
}
Expand Down Expand Up @@ -46,7 +46,7 @@ public void GenerateRandomFileName_ShouldGenerateEdgeCases()
while (true)
{
string fileName = randomSystem.Random.Shared.GenerateFileName();
if (fileNames.Contains(fileName))
if (fileNames.Contains(fileName, StringComparer.Ordinal))
{
break;
}
Expand Down
2 changes: 2 additions & 0 deletions Tests/Testably.Abstractions.Tests/TestHelpers/Polyfills/StringExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ internal static string Replace(
string newValue,
StringComparison comparisonType)
{
#pragma warning disable MA0074 // Avoid implicit culture-sensitive methods
return @this.Replace(oldValue, newValue);
#pragma warning restore MA0074 // Avoid implicit culture-sensitive methods
}
}
#endif
Loading