Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove direct mapbox-gl dependency #263

Closed
janruo opened this issue Jan 16, 2024 · 0 comments · Fixed by #265
Closed

Remove direct mapbox-gl dependency #263

janruo opened this issue Jan 16, 2024 · 0 comments · Fixed by #265
Assignees
@HoyosJuan
Labels
feature Something new that we could do

Comments

@janruo
Copy link

janruo commented Jan 16, 2024

Please remove the mapbox-gl dependency, and either add it as a peer dependency or offer the integration as a separate package. It inflates the bundle by 1 MB even if most users probably don't need it at all.

pic

[email protected]
@HoyosJuan HoyosJuan self-assigned this Jan 16, 2024
@HoyosJuan HoyosJuan added the feature Something new that we could do label Jan 16, 2024
@HoyosJuan HoyosJuan mentioned this issue Jan 16, 2024
Merged
8 tasks
@HoyosJuan HoyosJuan linked a pull request Jan 16, 2024 that will close this issue
feat: Moved mapbox to peer dependencies #265
Merged
8 tasks
@0JARVIS0 0JARVIS0 mentioned this issue Feb 7, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HoyosJuan HoyosJuan

Labels
feature Something new that we could do
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Moved mapbox to peer dependencies HoyosJuan/engine_components
2 participants
@janruo @HoyosJuan