Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Config option to sync overworld and aether time #2388

Open
2 of 3 tasks
cocona20xx opened this issue Nov 24, 2024 · 3 comments
Open
2 of 3 tasks

Feature Request: Config option to sync overworld and aether time #2388

cocona20xx opened this issue Nov 24, 2024 · 3 comments
Assignees
Labels
status/in-progress The issue is currently being worked on. type/request The issue is a feature or change request and does not fit into the other types.

Comments

@cocona20xx
Copy link

What Feature Types Apply to This Request?

Config, System

Other Type

No response

Is This an Enhancement to a Preexisting Feature?

  • I confirm this request is an enhancement to a feature already in The Aether.

What Is Your Feature Request?

A config option that, when enabled, causes the day/night cycle in the aether to correspond with the day/night cycle in the overworld once eternal day is banished (whether that be through killing a Sun Spirit for the first time or having eternal day disabled in the config as well).

Why Should It Be in the Mod?

For modpacks using Immersive Portal's dimension stacking feature, having a synchronized day/night cycle would help improve the illusion of seamlessness when looking up or down between dimensions, as demonstrated in these screenshots:
2024-11-23_19 32 53
2024-11-23_19 34 09
Depending how complicated of a feature this is, and how much time and physical capacity I have to dedicate to such a thing, I might be able to make a PR for this feature myself, hopefully?

Does This Feature Improve Compatibility With Another Mod?

Immersive Portals

Please Read and Confirm the Following

  • I have confirmed this feature is either in the original Aether mod, or improves parity between The Aether and Minecraft or other mods.
  • I have confirmed this suggestion is unique and has not been suggested already.
@cocona20xx cocona20xx added the type/request The issue is a feature or change request and does not fit into the other types. label Nov 24, 2024
@github-project-automation github-project-automation bot moved this to Back Log in The Aether Nov 24, 2024
@bconlon1 bconlon1 self-assigned this Nov 28, 2024
@bconlon1 bconlon1 moved this from Back Log to Next Up in The Aether Dec 1, 2024
@bconlon1 bconlon1 added the status/in-progress The issue is currently being worked on. label Dec 6, 2024
@bconlon1 bconlon1 moved this from Next Up to In Progress in The Aether Dec 6, 2024
@bconlon1
Copy link
Contributor

bconlon1 commented Dec 9, 2024

Yeah unfortunately this is not something I have been able to figure out, I'd be willing to accept a PR but I myself can't figure out a good way to handle this seamlessly due to how Minecraft handles level data and time between dimensions and the methods used for setting such.

@bconlon1 bconlon1 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in The Aether Dec 9, 2024
@cocona20xx
Copy link
Author

If I can figure out a good way to do it I'll make a PR, then.

@bconlon1
Copy link
Contributor

Thought of a potential solution that I'll have to try.

@bconlon1 bconlon1 reopened this Dec 18, 2024
@github-project-automation github-project-automation bot moved this from Done to Next Up in The Aether Dec 18, 2024
@bconlon1 bconlon1 moved this from Next Up to Review Requested in The Aether Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/in-progress The issue is currently being worked on. type/request The issue is a feature or change request and does not fit into the other types.
Projects
Status: Review Requested
Development

No branches or pull requests

2 participants