Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array too small #1

Open
HoverClub opened this issue Jan 14, 2023 · 0 comments
Open

Array too small #1

HoverClub opened this issue Jan 14, 2023 · 0 comments

Comments

@HoverClub
Copy link

It's been a long time but I thought I'd put this here in the hope it may help someone else!

Symptoms are the usual random crashing and string corruption issues caused by a char array declared too small! In PidProcessor::getFormattedResponse the array cValue is declared as 2 bytes when it should be 3 (2 chars plus terminator). The itoa function using it as the destination doesn't check array size so writes over the end with the null terminator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant