Fixed OpenGL Texture glad inclusion #673
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved inclusion of glad from header to implementation file
ViktorPopp
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue (if no issue has been made)
glad.h was included in the header file for OpenGLTexture, while all other OpenGL related classes included glad in their implementation files
Proposed fix
This moves the inclusion of glad to the implementation file of OpenGLTexture, to fit the same structure as the other GL related classes, as well as avoiding potential issues if/when implementing other APIs - as well as it keeps glad outside of the engine core
Additional context
The solution was tested on Windows 11 with Visual Studio 2022 on the latest version of the VC++ compiler