Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change manifest option to accept Buffer #53

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

TheDancingCode
Copy link
Collaborator

The manifest option no longer accepts a stream, only a Buffer. This alligns the plugin with Gulp's guidelines.

Closes #52.

BREAKING CHANGE: The `manifest` option no longer accepts a stream, only
a Buffer. This alligns the plugin with Gulp's guidelines.
Copy link

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 This looks great!! Thank you 🙇

@TheDancingCode TheDancingCode merged commit 9c29832 into master Oct 30, 2020
@TheDancingCode TheDancingCode deleted the manifest-as-buffer branch October 30, 2020 21:22
@github-actions
Copy link

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The manifest option abuses the gulp API
2 participants