Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back buildkit version #758

Merged
merged 4 commits into from
Jan 18, 2023
Merged

Roll back buildkit version #758

merged 4 commits into from
Jan 18, 2023

Conversation

jonathangreen
Copy link
Member

@jonathangreen jonathangreen commented Jan 16, 2023

Description

It seems like our docker builds have been failing a lot recently with the message:

#33 ERROR: failed to push ghcr.io/thepalaceproject/circ-webapp:sha-blahblah: failed to copy: io: read/write on closed pipe

Motivation and Context

It looks like there are two upstream issues where others are seeing this:
docker/build-push-action#761
moby/buildkit#3347

One suggestion was to roll back the version of buildkit we are using temporarily. It appears this issue is correlated with the release of buildkit v11, so this may fix the issue.

Once there is a fix for this in buildkit, we will have to revert this fix so we are getting the latest version again.

How Has This Been Tested?

Going to let CI run and see if it works.

@jonathangreen jonathangreen requested a review from a team January 16, 2023 20:37
@jonathangreen
Copy link
Member Author

Well this build worked. Not really proof this fixes the issue, since its intermittent anyway, but seems like this workaround couldn't hurt?

@jonathangreen
Copy link
Member Author

Added additional debug option suggested, so if it fails we get some logs that might be useful to send upstream to troubleshoot.

Copy link
Contributor

@io7m io7m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems harmless to me.

@jonathangreen jonathangreen merged commit 0af51f4 into main Jan 18, 2023
@jonathangreen jonathangreen deleted the bugfix/docker-build branch January 18, 2023 14:00
jonathangreen added a commit that referenced this pull request Jan 27, 2023
jonathangreen added a commit that referenced this pull request Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants