Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending the polish_names() function #14

Closed
CyuHat opened this issue Apr 2, 2024 · 1 comment
Closed

Extending the polish_names() function #14

CyuHat opened this issue Apr 2, 2024 · 1 comment

Comments

@CyuHat
Copy link

CyuHat commented Apr 2, 2024

Hi!
Thank you for your nice package. I think it is a nice and useful implementation janitor in Julia.

As a Follow up to the conversation I had with kdpsingh from the TidierData.jl package, I wanted to know if you are open to improve the polish_names() function in your package to match some specificities of the janitor::clean_names() function from R. Mainly the following points:

  • Removing/replacing accents (à, é, ô, ...)
  • Removing single and double quotes
  • Removing various brackets
  • Replacing "%" by "percent"
  • Replacing "#" by "number"
  • Removing other special characters ("!", ",", "$", ...)
  • Appending numbers to duplicate names (if needed)

I am still a beginner, but I can give a hand for the implementation as it will help me gain more experiences with Julia.

@TheRoniOne
Copy link
Owner

Fixed on version 1.1.0, check my PR for the details on how I did it if you are interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants