From 91384d848953d8c8b526a10f45d44f1bd38c62f0 Mon Sep 17 00:00:00 2001 From: Marlon Andrade Date: Thu, 27 Feb 2020 02:43:33 +0100 Subject: [PATCH] Don't set reactViewController view frame to whole screen (#1931) this fixes the case on any time you have a react view that displays the video, but it's being rendered with controls but not as a full screen (ie. easily reproducible when you have a tabbar for instance - the reactViewController.view frame shouldnt be the whole screen bounds). --- CHANGELOG.md | 4 ++++ ios/Video/RCTVideo.m | 6 +++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1d43a044bc..7b52c98c00 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ ## Changelog +### Version 5.1.0-alpha6 + +- Fix iOS bug which would break size of views when video is displayed with controls on a non full-screen React view. [#1931](https://github.com/react-native-community/react-native-video/pull/1931) + ### Version 5.1.0-alpha5 - Add support for react-native Windows Cpp/WinRT [#1893]((https://github.com/react-native-community/react-native-video/pull/1893)) diff --git a/ios/Video/RCTVideo.m b/ios/Video/RCTVideo.m index 113d9f2364..dde0dcb6f4 100644 --- a/ios/Video/RCTVideo.m +++ b/ios/Video/RCTVideo.m @@ -708,10 +708,10 @@ - (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(N if (!CGRectEqualToRect(oldRect, newRect)) { if (CGRectEqualToRect(newRect, [UIScreen mainScreen].bounds)) { NSLog(@"in fullscreen"); - } else NSLog(@"not fullscreen"); - [self.reactViewController.view setFrame:[UIScreen mainScreen].bounds]; - [self.reactViewController.view setNeedsLayout]; + [self.reactViewController.view setFrame:[UIScreen mainScreen].bounds]; + [self.reactViewController.view setNeedsLayout]; + } else NSLog(@"not fullscreen"); } return;