From be2fdc9d24ea00f6ef26cfce37075797b7d4be57 Mon Sep 17 00:00:00 2001
From: Hampton Maxwell <hmaxwell@ellation.com>
Date: Sat, 13 Oct 2018 19:37:21 -0700
Subject: [PATCH 1/5] Update to ExoPlayer 2.9.0

---
 android-exoplayer/build.gradle | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/android-exoplayer/build.gradle b/android-exoplayer/build.gradle
index 0e4804f994..4546a5975a 100644
--- a/android-exoplayer/build.gradle
+++ b/android-exoplayer/build.gradle
@@ -17,9 +17,8 @@ android {
 }
 
 dependencies {
-    //noinspection GradleDynamicVersion
     compileOnly "com.facebook.react:react-native:${safeExtGet('reactNativeVersion', '+')}"
-    implementation('com.google.android.exoplayer:exoplayer:2.8.4') {
+    implementation('com.google.android.exoplayer:exoplayer:2.9.0') {
         exclude group: 'com.android.support'
     }
 
@@ -28,7 +27,7 @@ dependencies {
     implementation "com.android.support:support-compat:${safeExtGet('supportLibVersion', '+')}"
     implementation "com.android.support:support-media-compat:${safeExtGet('supportLibVersion', '+')}"
 
-    implementation('com.google.android.exoplayer:extension-okhttp:2.8.4') {
+    implementation('com.google.android.exoplayer:extension-okhttp:2.9.0') {
         exclude group: 'com.squareup.okhttp3', module: 'okhttp'
     }
     implementation 'com.squareup.okhttp3:okhttp:3.11.0'

From d281936b82d909150b1036e86802ff49ae17f282 Mon Sep 17 00:00:00 2001
From: Hampton Maxwell <hmaxwell@ellation.com>
Date: Sat, 13 Oct 2018 20:08:22 -0700
Subject: [PATCH 2/5] Document version 4.0.0 breaking changes

---
 README.md | 37 ++++++++++++++++++++++++++++++++++---
 1 file changed, 34 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index 27c25742e5..7128d3649d 100644
--- a/README.md
+++ b/README.md
@@ -3,10 +3,13 @@
 A `<Video>` component for react-native, as seen in
 [react-native-login](https://github.com/brentvatne/react-native-login)!
 
-Requires react-native >= 0.40.0
+Version 4.x requires react-native >= 0.57.0
+Version 3.x requires react-native >= 0.40.0
 
 ### Version 4.0.0 breaking changes
-Version 4.0.0 now requires Android SDK 26 or higher to use ExoPlayer. This is the default version as of React Native 0.56 and will be required by Google for all apps in October 2018.
+Version 4.0.0 now requires Gradle 3 and Android SDK 26 or higher for Android in order to support ExoPlayer 2.9.0. React Native 0.57 uses Gradle 3 & SDK 27 by default. Google is dropping support for apps using SDKs older than 26 as of October 2018 and Gradle 2 as of January 2019. If you need to support an older React Native version, you should use react-native-video 3.2.1.
+
+Version 4.0.0 changes some behaviors and may require updates to your Gradle files.  See [Updating](#updating) for details.
 
 ### Version 3.0.0 breaking changes
 Version 3.0 features a number of changes to existing behavior. See [Updating](#updating) for changes.
@@ -974,7 +977,35 @@ To enable audio to play in background on iOS the audio session needs to be set t
 
 ## Updating
 
-### Version 3.0
+### Version 4.0.0
+
+#### Gradle 3 and SDK 26 requirement
+In order to support ExoPlayer 2.9.0, you must use version 3 or higher of the Gradle plugin. This is included by default in React Native 0.57. ExoPlayer 
+
+#### ExoPlayer 2.9.0 Java 1.8 requirement
+ExoPlayer 2.9.0 uses some Java 1.8 features, so you may need to enable support for Java 1.8 in your app/build.gradle file. If you get an error, compiling with ExoPlayer like:
+`Default interface methods are only supported starting with Android N (--min-api 24)`
+
+Add the following to your app/build.gradle file:
+```
+android {
+   ... // Various other settings go here
+   compileOptions {
+     targetCompatibility JavaVersion.VERSION_1_8
+   }
+}
+```
+
+#### ExoPlayer no longer detaches
+When using a router like the react-navigation TabNavigator, switching between tab routes would previously cause ExoPlayer to detach causing the video player to pause. We now don't detach the view, allowing the video to continue playing in a background tab. This matches the behavior for iOS. Android MediaPlayer will crash if it detaches when switching routes, so its behavior has not been changed.
+
+#### useTextureView now defaults to true
+The SurfaceView, which ExoPlayer has been using by default has a number of quirks that people are unaware of and often cause issues. This includes not supporting animations or scaling. It also causes strange behavior if you overlay two videos on top of each other, because the SurfaceView will [punch a hole](https://developer.android.com/reference/android/view/SurfaceView) through other views. Since TextureView doesn't have these issues and behaves in the way most developers expect, it makes sense to make it the default.
+
+TextureView is not as fast as SurfaceView, so you may still want to enable SurfaceView support. To do this, you can set `useTextureView={false}`.
+
+
+### Version 3.0.0
 
 #### All platforms now auto-play
 Previously, on Android ExoPlayer if the paused prop was not set, the media would not automatically start playing. The only way it would work was if you set `paused={false}`. This has been changed to automatically play if paused is not set so that the behavior is consistent across platforms.

From bda5c093cd4315a9723be2c1956e1e00870ec3f3 Mon Sep 17 00:00:00 2001
From: Hampton Maxwell <hmaxwell@ellation.com>
Date: Sat, 13 Oct 2018 20:13:58 -0700
Subject: [PATCH 3/5] Improve v4 breaking changes readability

---
 README.md | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index 7128d3649d..a707a78a5b 100644
--- a/README.md
+++ b/README.md
@@ -4,13 +4,18 @@ A `<Video>` component for react-native, as seen in
 [react-native-login](https://github.com/brentvatne/react-native-login)!
 
 Version 4.x requires react-native >= 0.57.0
+
 Version 3.x requires react-native >= 0.40.0
 
 ### Version 4.0.0 breaking changes
-Version 4.0.0 now requires Gradle 3 and Android SDK 26 or higher for Android in order to support ExoPlayer 2.9.0. React Native 0.57 uses Gradle 3 & SDK 27 by default. Google is dropping support for apps using SDKs older than 26 as of October 2018 and Gradle 2 as of January 2019. If you need to support an older React Native version, you should use react-native-video 3.2.1.
-
 Version 4.0.0 changes some behaviors and may require updates to your Gradle files.  See [Updating](#updating) for details.
 
+Version 4.0.0 now requires Android SDK 26+ and Gradle 3 plugin in order to support ExoPlayer 2.9.0. 
+
+React Native 0.57 uses Gradle 3 & SDK 27 by default. Google is dropping support for apps using SDKs older than 26 as of October 2018 and Gradle 2 as of January 2019. 
+
+If you need to support an older React Native version, you should use react-native-video 3.2.1.
+
 ### Version 3.0.0 breaking changes
 Version 3.0 features a number of changes to existing behavior. See [Updating](#updating) for changes.
 

From 430d4ea3a7197692b2f18790f60e85a3daa29b9b Mon Sep 17 00:00:00 2001
From: Hampton Maxwell <hmaxwell@ellation.com>
Date: Sat, 13 Oct 2018 20:14:06 -0700
Subject: [PATCH 4/5] Improve v4 breaking changes readability


From 159398057e0a86e21aee3b9e3bc222f25ff1ed7e Mon Sep 17 00:00:00 2001
From: Hampton Maxwell <hmaxwell@ellation.com>
Date: Sat, 13 Oct 2018 20:15:29 -0700
Subject: [PATCH 5/5] Combine SDK 26 / Gradle notes

---
 README.md | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/README.md b/README.md
index a707a78a5b..05bb6378da 100644
--- a/README.md
+++ b/README.md
@@ -10,9 +10,7 @@ Version 3.x requires react-native >= 0.40.0
 ### Version 4.0.0 breaking changes
 Version 4.0.0 changes some behaviors and may require updates to your Gradle files.  See [Updating](#updating) for details.
 
-Version 4.0.0 now requires Android SDK 26+ and Gradle 3 plugin in order to support ExoPlayer 2.9.0. 
-
-React Native 0.57 uses Gradle 3 & SDK 27 by default. Google is dropping support for apps using SDKs older than 26 as of October 2018 and Gradle 2 as of January 2019. 
+Version 4.0.0 now requires Android SDK 26+ and Gradle 3 plugin in order to support ExoPlayer 2.9.0. Google is dropping support for apps using SDKs older than 26 as of October 2018 and Gradle 2 as of January 2019. React Native 0.57 defaults to Gradle 3 & SDK 27.
 
 If you need to support an older React Native version, you should use react-native-video 3.2.1.