Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocelot.Provider.Consul Support Tag #1298

Closed
842549829 opened this issue Jul 24, 2020 · 3 comments
Closed

Ocelot.Provider.Consul Support Tag #1298

842549829 opened this issue Jul 24, 2020 · 3 comments
Labels
waiting Waiting for answer to question or feedback from issue raiser

Comments

@842549829
Copy link

842549829 commented Jul 24, 2020

Expected Behavior / New Feature

var queryResult = await _consul.Health.Service(_config.KeyOfServiceInConsul, string.Empty, true);
Tag is string.Empty

Actual Behavior / Motivation for New Feature

Old

"Routes":[
    {"ServiceName":"ServiceName"}
]

New

{
    "Routes":[
        {
            "Service":{
                "Name":"ServiceName",
                "Tag":[
                    "v1",
                    "v2",
                    "v3"
                ],
                "Datacenter":"dc1"
            }
        }
    ]
}
@raman-m
Copy link
Member

raman-m commented Mar 27, 2024

@842549829 What's your goal having Consul tags?
Will you personally contribute to implement this feature?

@raman-m
Copy link
Member

raman-m commented Mar 27, 2024

@ggnaegi I'm not sure, but this issue about adding new Tag property to Service entry model, right?
If Yes, we could add the property.

@raman-m raman-m added the waiting Waiting for answer to question or feedback from issue raiser label Mar 27, 2024
@raman-m
Copy link
Member

raman-m commented Jun 15, 2024

Dear @842549829,
Update version to 23.3.0
With Consul Service Builder and Metadata features develop whatever you want.
See more details in PR #2067

You have the right to reopen this issue in the future if you come with a PR ready

If you want official properties in route options then you have to contribute!

@raman-m raman-m closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting Waiting for answer to question or feedback from issue raiser
Projects
None yet
Development

No branches or pull requests

2 participants