Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Thinkpad T420 #14

Open
qiyunluoxing opened this issue Dec 20, 2020 · 4 comments
Open

Support for Thinkpad T420 #14

qiyunluoxing opened this issue Dec 20, 2020 · 4 comments
Labels
help wanted Extra attention is needed New Device Request for a new device to be added

Comments

@qiyunluoxing
Copy link

Is it possible to add Thinkpad T420 support?
I have dumped the factory firmware of Thinkpad T420 and flashed coreboot. I am happy to assist with testing.

@Thrilleratplay
Copy link
Owner

If it has Intel video, adding a T420 should be trivial. The only reason I do not have it included is because I do not own one to verify it works when a new version of coreboot is released. It isn't that I do not want to support it, I do not want to accidentally leave someone with device that does not boot correctly. It is very unlikely as the T420 with Intel video is almost identical to the X220 config,

Looking at the forks, it seems like someone already created the T420 along with bootsplash. https://github.com/MarieKirya/coreboot-builder-scripts/tree/add-t420-support

@Thrilleratplay Thrilleratplay added help wanted Extra attention is needed New Device Request for a new device to be added labels Dec 20, 2020
@qiyunluoxing
Copy link
Author

Thank you for your advice.

@szarpaj
Copy link

szarpaj commented Mar 19, 2021

I can test. Let's make this a real thing. :)

@Thrilleratplay
Copy link
Owner

@szarpaj You are welcome to create a pull request. If you copy the x220 directory and change the device to be t420 that may be enough. If you do this, please remove any defconfig versions you did not test.

My only issue with the above fork is that is uses the VGA blob. I want to keep the devices as close to one another as possible and if there is an issue with this device, I do not have a T420 to debug the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed New Device Request for a new device to be added
Projects
None yet
Development

No branches or pull requests

3 participants