Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problematic compat practices leading to unintended Pkg resolver resolution #244

Closed
mestinso opened this issue Sep 5, 2024 · 5 comments
Closed

Comments

@mestinso
Copy link

mestinso commented Sep 5, 2024

I"m noticing that compat updates like the following:
ThummeTo/FMIBase.jl@80e9151
can have the opposite effect of what is intended in some cases.

From a clean FML.jl install, Pkg is deciding to stay with the lower FMIBase.jl version (1.06) in order to maintain the higher DiffEqCallbacks.jl verslon (3.8).

With that said, if there are really problems with DiffEqCallbacks.jl 3.8, your change seems natural. It's not clear to me if there are better Pkg.jl compat practices that should be used for situations like this or if this is Pkg.jl issue.

My thinking is that since FMIBase depends on DiffEqCallbacks (and not the other way around), it's version being up to date should take precedence. I'm tempted to open an issue over at Pkg.jl, but a) I wanted to discuss the issue here first, and b) ideally i'd like to describe the problem as simple as possible with a MWE before taking it to Pkg.jl issue board.

Anyways, here is the situation i ran on julia 1.11 with FMI.jl only installed:
image

@ThummeTo
Copy link
Owner

ThummeTo commented Sep 10, 2024

That is interesting! Indeed, there were issues with DiffEqCallbacks 3.8 that's why the downgrade.

The fact that DiffEqCallbacks keeps FMIBase on a lower release seems strange... can you try removing the explicit dependency to DiffEqCallbacks and check if this solves the issue? Maybe resolve afterward too?

@ThummeTo
Copy link
Owner

Ok, I can reproduce this, but it feels (as you are saying) not very intuitive...
I will fix FMIImport v1.0.6 to FMIBase v1.0.8 (and upper), so that the next FMI/FMIFlux releases will force the new FMIBase release

@ThummeTo ThummeTo mentioned this issue Sep 11, 2024
@ThummeTo
Copy link
Owner

should be closed with v0.14.1 - please reopen if not

@mestinso
Copy link
Author

@ThummeTo Confirmed resolved here. Any lingering thoughts from your point of view with respect reporting the issue to Pkg.jl? I will note that I previously saw this same type of issue with PythonCall.jl when a dependency was rolled back.

@ThummeTo
Copy link
Owner

IMO this behavior is unexpected, but I don't know what the intended behavior of Pkg is. If this is not intended, opening an issue would be definitely the right way to go...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants