Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Ghosting in Token View #229

Open
acnebs opened this issue Dec 7, 2021 · 5 comments
Open

Image Ghosting in Token View #229

acnebs opened this issue Dec 7, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@acnebs
Copy link
Contributor

acnebs commented Dec 7, 2021

Expected Behavior

When you load a token that has no image, it should immediately show no image.

Current Behavior

If you load a token that has an image and then open a token that does not have an image, sometimes the image will stay there indefinitely, as if that image belongs to the first one. The image should immediately unload / not display if it doesn't have one.

Steps to Reproduce

  1. Open an NFT that has a working image from the Token Testing wallet
  2. Open the dorritos NFT
  3. The dorritos detail page will continue displaying the image from step (1).
@acnebs acnebs added the bug Something isn't working label Dec 7, 2021
@acnebs
Copy link
Contributor Author

acnebs commented Dec 7, 2021

This is the data payload for the dorritos token detail, might be helpful:

{
  d86d6588839911479e6b6bcd968a46fee0a0fc6da8cfb8b779e5562886f42af8: {
    result: 'success',
    tokenid: 'd86d6588839911479e6b6bcd968a46fee0a0fc6da8cfb8b779e5562886f42af8',
    owner: '02c00f9800cfd2eeb1775729d3783357b1db193448712076bf746f7b5058a3241e',
    name: 'dorritos',
    supply: 1,
    description: 'dorry dorritos',
    data: 'f701020f687474703a2f2f6c696e6b2e636f6d0314',
    dataAsJson: {
      url: 'http://link.com',
      royalty: 20
    },
    version: 1,
    IsMixed: 'yes',
    height: 147134
  }
}

@lenilsonjr
Copy link
Contributor

@acnebs is this one happening on development or did you test this against my latest PR?

@acnebs
Copy link
Contributor Author

acnebs commented Dec 7, 2021

Hmm, let me check, I think I was in development, great news if you fixed it already haha.

@acnebs
Copy link
Contributor Author

acnebs commented Dec 7, 2021

@lenilsonjr Hmmm nope, still a problem, see here, this is the image from Silvia Is My Matey FST which I clicked before loading dorritos, running on feature/token-creation-nspv-integration:

Screen Shot 2021-12-07 at 8 35 57 PM

Best guess: the problem is that the link associated with the dorritos token does not resolve before timeout (http://link.com) and that's breaking something somewhere.

@NutellaLicka
Copy link
Contributor

This might not be that helpful, but I've definitely seen it on the latest token creation tool testing build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants