Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe scrape timeout too short when using ollama LLM on my setup #556

Closed
zergar opened this issue Nov 24, 2024 · 1 comment · Fixed by #567
Closed

Recipe scrape timeout too short when using ollama LLM on my setup #556

zergar opened this issue Nov 24, 2024 · 1 comment · Fixed by #567

Comments

@zergar
Copy link

zergar commented Nov 24, 2024

Hei,

Thanks for the new 0.6.3 release and KitchenOwl in general. I'm using it alot.

Unfortunately, I ran into a timeout with the new recipe LLM scraping functionality as my ollama deployment is not backed by a strong enough server to respond to the request within 15 seconds, as required by

static const Duration _TIMEOUT_SCRAPE = Duration(seconds: 15);
.This means I cannot use this new feature. Actually, when looking at the Network Debugger in my browser, I can see the Log message mentioning the timeout after 15 seconds, and the request completing sucessfully after 17 seconds.

I can imagine a couple of solutions for this issue:

  1. Have the scraping timeout defined by a frontend ENV var from the server side
  2. Have the scraping timeout defined by a settings parameter in the UI itself
  3. Display an error message akin to "this takes longer than expected. Do you want to abort?" after 15 seconds, and then if the request succeeds later than expected, display the successful scrape.
  4. Increasing the timeout like in fix: increase scrape timeout to 15s #454 would also work, but I would deem this a a worse solution since the timeout can be very setup-specific.

Thanks!

@TomBursch TomBursch moved this to Next Up in KitchenOwl Project Nov 27, 2024
@TomBursch TomBursch linked a pull request Dec 4, 2024 that will close this issue
@TomBursch
Copy link
Owner

Thanks for the issue, I think your third solution is a good one. I increased the timeout to 5 minutes, but displaying a message after 15 seconds.

@github-project-automation github-project-automation bot moved this from Next Up to Ready for Testing in KitchenOwl Project Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Testing
Development

Successfully merging a pull request may close this issue.

2 participants