Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subtyping in dict service #7115

Closed
wants to merge 25 commits into from
Closed

Fix subtyping in dict service #7115

wants to merge 25 commits into from

Commits on Nov 7, 2024

  1. remove unnecessary nesting in DictApiEndopoints

    Marcel Philipiak committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    d7893c6 View commit details
    Browse the repository at this point in the history

  2. Fixed improper subtyping in CanBeSubclassDeterminer

    Marcel Philipiak committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    d5796f3 View commit details
    Browse the repository at this point in the history

  3. regenerated openapi

    Marcel Philipiak committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    7f14f49 View commit details
    Browse the repository at this point in the history

  4. Changed type in UIProcess

    Marcel Philipiak committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    1d5ce0c View commit details
    Browse the repository at this point in the history

  5. extract isAssignable

    Marcel Philipiak committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    9bd74d5 View commit details
    Browse the repository at this point in the history

  6. Added CanBeSubclassDeterminerSpec

    Marcel Philipiak committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    28ff753 View commit details
    Browse the repository at this point in the history

  7. comment fixup

    Marcel Philipiak committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a881083 View commit details
    Browse the repository at this point in the history

  8. Fix decimal typing in SubclassDeterminerSpec

    Marcel Philipiak committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    108a345 View commit details
    Browse the repository at this point in the history

  9. Fix numerical typing in SubclassDeterminerSpec

    Marcel Philipiak committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    d073fd1 View commit details
    Browse the repository at this point in the history

  10. CanBeSubclassDeterminerSpec fixes

    Marcel Philipiak committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    2e50536 View commit details
    Browse the repository at this point in the history

  11. Extracted ConversionDeterminer and SubclassDeterminer

    Marcel Philipiak committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    50c59b5 View commit details
    Browse the repository at this point in the history

  12. Cleaned up tests and naming

    Marcel Philipiak committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    81d10a0 View commit details
    Browse the repository at this point in the history

  13. TypingResultSpec fix

    Marcel Philipiak committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    43706dc View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. feat: Add StrictConversionDeterminer for type conversion validation

    Marcel Philipiak committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    6385259 View commit details
    Browse the repository at this point in the history

  2. Determiner remakes for PR

    Marcel Philipiak committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    209ab0c View commit details
    Browse the repository at this point in the history

  3. rename for pr

    Marcel Philipiak committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    e4724a2 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Update components-api/src/test/scala/pl/touk/nussknacker/engine/api/t… 

    …yped/SubclassDeterminerSpec.scala

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    @Diamekod0221 @coderabbitai
    Diamekod0221 and coderabbitai[bot] authored Nov 20, 2024
    Configuration menu
    Copy the full SHA
    c7296a0 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. pr changes - delte test cases

    Marcel Philipiak committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    07af990 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. simplify conversion check (#7220) 

    * simplify conversion check

* changes to TypeConversionHandler

* test fixes

---------

Co-authored-by: Marcel Philipiak <[email protected]>
    @mslabek
    mslabek and Marcel Philipiak authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    6716c23 View commit details
    Browse the repository at this point in the history

  2. tests for AssignabilityDeterminerSpec

    Marcel Philipiak committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    6f7187c View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Pr changes to AssignabilityDeterminerSpec and AssignabilityDeterminer… 

    …. TypeConversionHandler logic branchout
    Marcel Philipiak committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    1118186 View commit details
    Browse the repository at this point in the history

  2. Update designer/server/src/test/scala/pl/touk/nussknacker/ui/api/Dict… 

    …ApiHttpServiceSpec.scala

Co-authored-by: Mateusz Słabek <[email protected]>
    @Diamekod0221 @mslabek
    Diamekod0221 and mslabek authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    06ceea9 View commit details
    Browse the repository at this point in the history

  3. Update components-api/src/main/scala/pl/touk/nussknacker/engine/api/t… 

    …yped/AssignabilityDeterminer.scala

Co-authored-by: Mateusz Słabek <[email protected]>
    @Diamekod0221 @mslabek
    Diamekod0221 and mslabek authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    ce5448a View commit details
    Browse the repository at this point in the history

  4. Changes to MigrationGuide.md and comment in AssignabilityDeterminer

    Marcel Philipiak committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    155a359 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/fix_subtyping_in_DictService' in… 

    …to fix_subtyping_in_DictService
    Marcel Philipiak committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    4204af0 View commit details
    Browse the repository at this point in the history