Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore becomes .npmignore on run #64

Closed
JRJurman opened this issue Aug 3, 2019 · 6 comments
Closed

.gitignore becomes .npmignore on run #64

JRJurman opened this issue Aug 3, 2019 · 6 comments

Comments

@JRJurman
Copy link
Member

JRJurman commented Aug 3, 2019

Summary

For some reason, the .gitignore file becomes an .npmignore file on running tram-one-express... Not sure why, or when this regression happened.

This could be a documented feature of npm / node. Requires investigation.

@JRJurman
Copy link
Member Author

JRJurman commented Oct 14, 2019

This issue does not appear to happen when running the npm run generate-example command in the project, only when running the npx tram-one-express command. This has been verified on both Mac OS and Windows.

@chtinahow
Copy link
Contributor

Similar issue that was seen in this thread: npm/npm#1862

@abhishekr700
Copy link
Contributor

if there's a empty .npmignore, .gitignore would not be touched

@JRJurman
Copy link
Member Author

@abhishekr700 after looking at the above issue, I'm not sure that's the case (also, I don't think we would actually want an empty one, rather something that is a copy of our existing gitignore).

Where did you see that was the case (or do you have an example running where that is the case)?

@abhishekr700
Copy link
Contributor

I read something similar here npm/npm#3763

@JRJurman
Copy link
Member Author

the latter comments (and the ones on the issue @chtinahow linked) seem to indicate that regardless of what files you have, all .gitignores will be converted. if you have a working example though, that would be awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants