From 43a58aae8e44d1a643cc5cd09260080f058cc38b Mon Sep 17 00:00:00 2001 From: Scott Determan Date: Tue, 13 Dec 2022 19:21:22 -0500 Subject: [PATCH] Fix clang 15 warnings: (#4325) Clang warned about the code removed in this patch with the warning: ``` warning: out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated [-Wdeprecated] ``` --- src/ripple/app/misc/impl/TxQ.cpp | 2 -- src/ripple/core/impl/Config.cpp | 2 -- src/ripple/rpc/impl/Status.cpp | 2 -- src/test/unit_test/multi_runner.cpp | 5 ----- 4 files changed, 11 deletions(-) diff --git a/src/ripple/app/misc/impl/TxQ.cpp b/src/ripple/app/misc/impl/TxQ.cpp index 0eeec8d62ae..59559cf24c6 100644 --- a/src/ripple/app/misc/impl/TxQ.cpp +++ b/src/ripple/app/misc/impl/TxQ.cpp @@ -78,8 +78,6 @@ increase(FeeLevel64 level, std::uint32_t increasePercent) ////////////////////////////////////////////////////////////////////////// -constexpr FeeLevel64 TxQ::baseLevel; - std::size_t TxQ::FeeMetrics::update( Application& app, diff --git a/src/ripple/core/impl/Config.cpp b/src/ripple/core/impl/Config.cpp index f8d8878a771..c2cfb14d21d 100644 --- a/src/ripple/core/impl/Config.cpp +++ b/src/ripple/core/impl/Config.cpp @@ -263,8 +263,6 @@ getEnvVar(char const* name) return value; } -constexpr FeeUnit32 Config::TRANSACTION_FEE_BASE; - Config::Config() : j_(beast::Journal::getNullSink()), ramSize_(detail::getMemorySize()) { diff --git a/src/ripple/rpc/impl/Status.cpp b/src/ripple/rpc/impl/Status.cpp index 0890daee6f9..e9e64da7ac0 100644 --- a/src/ripple/rpc/impl/Status.cpp +++ b/src/ripple/rpc/impl/Status.cpp @@ -23,8 +23,6 @@ namespace ripple { namespace RPC { -constexpr Status::Code Status::OK; - std::string Status::codeString() const { diff --git a/src/test/unit_test/multi_runner.cpp b/src/test/unit_test/multi_runner.cpp index 5cd69111b42..c1111e4cfeb 100644 --- a/src/test/unit_test/multi_runner.cpp +++ b/src/test/unit_test/multi_runner.cpp @@ -389,11 +389,6 @@ multi_runner_base::add_failures(std::size_t failures) any_failed(failures != 0); } -template -constexpr const char* multi_runner_base::shared_mem_name_; -template -constexpr const char* multi_runner_base::message_queue_name_; - } // namespace detail //------------------------------------------------------------------------------