Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap arguments for fixture #116

Closed
sz-piotr opened this issue Jul 19, 2019 · 1 comment · Fixed by #215
Closed

Swap arguments for fixture #116

sz-piotr opened this issue Jul 19, 2019 · 1 comment · Fixed by #215
Labels
waffle-3.0.0 Part of the improvements for Waffle 3

Comments

@sz-piotr
Copy link
Contributor

Currently the signature for fixture is async function fixture (provider, wallets). Since the provider argument is very rarely used compared to wallets I propose a breaking change for the next version of waffle that swaps the arguments. The new signature would be:

async function fixture (wallets: Wallet[], provider: providers.Provider)
@sz-piotr sz-piotr added the waffle-3.0.0 Part of the improvements for Waffle 3 label Jul 19, 2019
@sz-piotr
Copy link
Contributor Author

sz-piotr commented Nov 8, 2019

part of #155

@sz-piotr sz-piotr closed this as completed Nov 8, 2019
@sz-piotr sz-piotr reopened this Dec 20, 2019
@sz-piotr sz-piotr mentioned this issue Dec 20, 2019
Closed
33 tasks
@rzadp rzadp mentioned this issue Apr 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
waffle-3.0.0 Part of the improvements for Waffle 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Swap arguments for fixture rzadp/Waffle
1 participant
@sz-piotr