Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup published package #164

Closed
krzkaczor opened this issue Dec 19, 2019 · 2 comments · Fixed by #171
Closed

Cleanup published package #164

krzkaczor opened this issue Dec 19, 2019 · 2 comments · Fixed by #171

Comments

@krzkaczor
Copy link
Contributor

Probably you don't want to include .vscode and original ts files in a published package.

I highly recommend using package.json's files instead of .npmignore.

@krzkaczor
Copy link
Contributor Author

krzkaczor commented Dec 19, 2019

One more thing: you explicitly target node 10 (in package.json) yet transpiled code targets some ancient architecture (es5?) making code slower and harder to read (I often read transpiled output while debugging).

@sz-piotr
Copy link
Contributor

This is a valid point. We should update the build scripts to address that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants