Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'instance_seg' and 'direction_pred' both use 'self.up1_embedded.' is it intended? #37

Open
minhyeok-heo opened this issue Nov 1, 2022 · 0 comments

Comments

@minhyeok-heo
Copy link

minhyeok-heo commented Nov 1, 2022

I just found that --direction-pred only works when --instance-seg is activated

because direction_pred and instance_seg share the self.up1_embedded layer

x_direction = self.up1_embedded(x2, x1)

i guessed it is kinda typo. because there is another layer designed for direction_pred, 'self.up1_direction'. but never used

self.up1_direction = Up(64 + 256, 256, scale_factor=4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant