Logger extensions now also count the warnings #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I cannot believe I messed up that previous PR (TypeStrong#1205), but the extensions of the `Logger` class did not count the warnings. Solved this by removing the error counting code from the child classes, and called the super method instead. This ensures that both the error count and the warning count increases.
|
My bad as well - I assumed child classes were well behaved, which is not an assumption that can be made with TypeDoc yet unfortunately! Thanks for the fix! Should be able to do a release this weekend |
|
That was my assumption as well. Great was my surprise after upgrading that the logger said zero warnings while the log indicated otherwise. |
|
Released in 0.16.11 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cannot believe I messed up that previous PR (#1205), but the extensions of the
Loggerclass did not count the warnings.Solved this by removing the error counting code from the child classes, and called the super method instead.
This ensures that both the error count and the warning count increases.