-
-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove specific version of typescript from dependencies #556
Comments
We have a PR #549 open to update TypeScript to 2.4 but work does need to be done to make the TypeScript dependency less brittle. |
all right, so I found out in the end that the culprit is sorry for bugging you folks. |
I'm going to close this for now. If you have it in your own dependencies it certainly shouldn't replace it. That's the reason we use |
Suddenly all my builds started to fail https://github.com/Hotell/typescript-lib-starter/pulls
The culprit here is typedoc becuase it has specific version of typescript as direct project
dependencies
which overrides localnode_modules/.bin/tsc
symlink to use this TS instead of TS that is used by the project.This is a big deal.
How to fix this:
depencies
to^2.3.4
I can submit PR if you're willing to go through it and merge it eventually after LGTM :)
cheers
The text was updated successfully, but these errors were encountered: