Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove specific version of typescript from dependencies #556

Closed
Hotell opened this issue Jul 15, 2017 · 4 comments
Closed

fix: remove specific version of typescript from dependencies #556

Hotell opened this issue Jul 15, 2017 · 4 comments
Labels
wontfix Declining to implement

Comments

@Hotell
Copy link

Hotell commented Jul 15, 2017

Suddenly all my builds started to fail https://github.com/Hotell/typescript-lib-starter/pulls

The culprit here is typedoc becuase it has specific version of typescript as direct project dependencies which overrides local node_modules/.bin/tsc symlink to use this TS instead of TS that is used by the project.

This is a big deal.

image

How to fix this:

  • move typescript to peerDependencies ( best solution ) ( this would be a breaking change for your library from perspective of semver )
  • change typescript version in your depencies to ^2.3.4

I can submit PR if you're willing to go through it and merge it eventually after LGTM :)

cheers

@aciccarello
Copy link
Collaborator

We have a PR #549 open to update TypeScript to 2.4 but work does need to be done to make the TypeScript dependency less brittle.

@aciccarello
Copy link
Collaborator

For reference, this has been discussed mainly in #145 (though also noted in #369).

There is also some relevant discussion in #310

@Hotell
Copy link
Author

Hotell commented Jul 21, 2017

all right, so I found out in the end that the culprit is yarn !!! wooot :(

sorry for bugging you folks.

yarnpkg/yarn#3983

@blakeembrey
Copy link
Member

I'm going to close this for now. If you have it in your own dependencies it certainly shouldn't replace it. That's the reason we use dependencies - we have a specific version requirement for TypeScript and we can't just use any version today. As a result, we can not use peerDependencies or have it automatically use later versions.

@blakeembrey blakeembrey added the wontfix Declining to implement label Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix Declining to implement
Projects
None yet
Development

No branches or pull requests

3 participants