Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using JSON for configuration settings #243

Open
4 tasks
astrochun opened this issue Jul 26, 2021 · 0 comments
Open
4 tasks

Switch to using JSON for configuration settings #243

astrochun opened this issue Jul 26, 2021 · 0 comments
Labels
curation Pertains to aspects of curation, including workflow management enhancement New feature or request management
Milestone

Comments

@astrochun
Copy link
Contributor

Summary

In the past, we used a config INI file and configparser to parse the configuration. This was identical to how we did it with ReQUIAM. Over time, the complexity of configuration for LD-Cool-P grew. For example, handling multiple Deposit Agreement survey required a string version of a list that was interpreted via ast.literal.
To simplify this, I recommend moving toward using a config.json file following a JSON schema. This will allow for long-term support of more complex configuration settings. It will also be easy to load the configuration using the built-in json library.

Objectives

A simplification of the configuration. While this is a change to the config file, we should ensure that it's backwards compatible. Namely that both .ini and .json files can be imported.

Proposal

  • Build a .json template for the configuration
  • Add in support for .json config file through dict_load
  • Construct .json files for deployment
  • Test a number of scripts with the .json settings

Testing notes

See above todo action.

Additional notes

Implemented in: TBD

@astrochun astrochun added curation Pertains to aspects of curation, including workflow management enhancement New feature or request management labels Jul 26, 2021
@astrochun astrochun added this to the v1.2.0 milestone Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
curation Pertains to aspects of curation, including workflow management enhancement New feature or request management
Projects
None yet
Development

No branches or pull requests

1 participant