Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload bag with changed curation files #61

Open
1 task done
zoidy opened this issue Aug 14, 2023 · 0 comments
Open
1 task done

Upload bag with changed curation files #61

zoidy opened this issue Aug 14, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@zoidy
Copy link
Collaborator

zoidy commented Aug 14, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Description

Currently, if a preservation bag exists on preservation storage, only changes in the Figshare data/metadata will result in detecting that a bag being processed is different than the corresponding bag on preservation storage (via the hash in the bag name).

This means that if there are any changes to any other part of the bagged content that is not coming from the Figshare side, (e.g., curation metadata), ReBACH will show a message saying that the bag being created is a duplicate of an existing bag and will not upload it to preservation storage. This is undesirable sometimes since curation files may be added/updated later. However, replacing the existing file when curation data changes is not desirable ALL the time (since it could be the result of an error)

Suggested Implementation

Implement in two phases
1. Add a check to see if the bag to be uploaded is a different size than the one in preservation if the hash in the bag name is the same. Display a warning if not (to allow checking the logs)
2. Add a config and/or commandline flag to enable overwriting existing bags with the same name

Edit: phase 1 isn't possible because Dart handles bag creation and upload so there is no easy way to check the bag size before it's uploaded. Therefore, the only way updated curation files can be uploaded is to overwrite the bag without the check (overwriting is already possible by setting the flag in the bagger config).

@zoidy zoidy added the enhancement New feature or request label Aug 14, 2023
@zoidy zoidy linked a pull request Aug 17, 2023 that will close this issue
2 tasks
@zoidy zoidy changed the title Detect when curation files have changed Upload bag with changed curation files Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant