Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fengs mapper issues #24

Open
profLewis opened this issue Mar 10, 2022 · 7 comments
Open

Fengs mapper issues #24

profLewis opened this issue Mar 10, 2022 · 7 comments

Comments

@profLewis
Copy link
Contributor

@jgomezdans @MarcYin

When do you assume harvesting is? I can see field notes mention ‘ready for harvesting’ but don’t seem to say when that was. Surely we should constraint or at least check that we have that right.

The autofit doesn’t seem to be working – is that broken ATM?

Im playing with Fengs maize mapper, and it would be really useful if GS 1 and 2 were indicated on the plots … I can see you can read off when 1, 2.0 GS is, but that’s quite hard to do. Esp since 1 isnt shown directly. Feng - Can you pls show GS 1 and GS 2 as vertical lines in both the modelling plots and the data plots?

Also, once you go into LAI movie mode, there doesn’t seem a way to switch back to showing yield map without reloading, which is clunky. Is that fixable?

Also, whilst there is ‘help’ for the terms used on the sliders, there is no help for the quantities plotted … also, no units given for these (that could be in the help). It is hard to work out what you are seeing.

Also, I cant see the measured yield data anywhere in the plots - where is that?

@profLewis
Copy link
Contributor Author

Also, for Planet wavebands can you label as Blue Green Red and near infrared?

@profLewis
Copy link
Contributor Author

What ever happened to the S2 fitting? where is that shown? I thought we were going to see Cab comparisons for that?

@profLewis
Copy link
Contributor Author

There is a mismatch in date specification on the woofs slider part -- slider is date and plots are doy and it isn't easy to see relationship

@MarcYin
Copy link
Contributor

MarcYin commented Mar 10, 2022

@jgomezdans @MarcYin

When do you assume harvesting is? I can see field notes mention ‘ready for harvesting’ but don’t seem to say when that was. Surely we should constraint or at least check that we have that right.

In the comments tab, it lists the date of the comments and it shows both the date and day of year for that comment.

The autofit doesn’t seem to be working – is that broken ATM?

The auto fit is waiting for the updated ensembles with the new prior.

Im playing with Fengs maize mapper, and it would be really useful if GS 1 and 2 were indicated on the plots … I can see you can read off when 1, 2.0 GS is, but that’s quite hard to do. Esp since 1 isnt shown directly. Feng - Can you pls show GS 1 and GS 2 as vertical lines in both the modelling plots and the data plots?

The plot is complicated enough, but I can add the DVS=1 and DVS=2 lines and possibly remove the DVS line

Also, once you go into LAI movie mode, there doesn’t seem a way to switch back to showing yield map without reloading, which is clunky. Is that fixable?

There is a layer control you can determine which layer you want to see

Also, whilst there is ‘help’ for the terms used on the sliders, there is no help for the quantities plotted … also, no units given for these (that could be in the help). It is hard to work out what you are seeing.

The help terms for the outputs are hard to add as they are plots rather than labels, but I will have a try

Also, I cant see the measured yield data anywhere in the plots - where is that?

The measured yields are plated as horizontal yellow lines in the TWSO with grey shading showing 1 sigma

@MarcYin
Copy link
Contributor

MarcYin commented Mar 10, 2022

Also, for Planet wavebands can you label as Blue Green Red and near infrared?

Will do

@MarcYin
Copy link
Contributor

MarcYin commented Mar 10, 2022

What ever happened to the S2 fitting? where is that shown? I thought we were going to see Cab comparisons for that?

Did not show that, but I though we are only going to show the Planet one, but will try to add as another tab.....

@MarcYin
Copy link
Contributor

MarcYin commented Mar 10, 2022

There is a mismatch in date specification on the woofs slider part -- slider is date and plots are doy and it isn't easy to see relationship

The date and doy are synchronised in the slider, so you can get both information at the same time rather than only showing date or doy...but I can change that to doy easily...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants